Merged
Conversation
molant
reviewed
Nov 10, 2021
Co-authored-by: Antón Molleda <molant@users.noreply.github.com>
codebytere
approved these changes
Nov 11, 2021
erickzhao
reviewed
Nov 15, 2021
Co-authored-by: Erick Zhao <erick@hotmail.ca>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
ckerr
approved these changes
Nov 16, 2021
erickzhao
approved these changes
Nov 16, 2021
Member
|
(slightly tacky to approve a PR that I co-wrote? 😄 This is to indicate approval of the changes) |
malept
reviewed
Nov 16, 2021
Comment on lines
+51
to
+53
| ### Building Native Modules | ||
|
|
||
| If your project uses node-gyp to build native modules, you may need to call it with `--force-process-config` depending on your project's setup and your Electron version. More information about this change can be found at [#2497](https://github.com/nodejs/node-gyp/pull/2497). |
Member
There was a problem hiding this comment.
Perhaps note that electron-rebuild@>=3.2.5 supports this automatically, so folks using -rebuild or Electron Forge only need to update their dependencies?
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial draft of Electron 16 blog post
@electron/wg-releases , @ckerr
Please add a comment for items you think we should highlight in the blog post.
Merge target: Nov 16th, after 16.0.0 releases successfully